Added routing for sponsor package and code of conduct #6

Merged

wfryan merged 16 commits from adding-sponsor-and-conduct into master

2022-12-20 20:15:05 -05:00

wfryan commented

2022-12-20 18:45:20 -05:00

(Migrated from github.com)

No description provided.

Muirrum (Migrated from github.com) requested changes 2022-12-20 18:48:43 -05:00

goathacks/__init__.py

Muirrum (Migrated from github.com) commented

2022-12-20 18:47:27 -05:00

Why are these two separate routes? You could just link to the one PDF.

    #Code of conduct 
    @app.route('/conduct/conduct.pdf')
    def conduct(path):
        return url_for('static', filename='conduct.pdf')

Why are these two separate routes? You could just link to the one PDF. ```suggestion #Code of conduct @app.route('/conduct/conduct.pdf') def conduct(path): return url_for('static', filename='conduct.pdf') ```

goathacks/templates/header.html

Muirrum (Migrated from github.com) commented

2022-12-20 18:48:41 -05:00

              <a class="nav-link" href="{{ url_for('conduct') }}">Code of Conduct</a>

You always want to use url_for in case the root URL or the path to the route changes.

```suggestion <a class="nav-link" href="{{ url_for('conduct') }}">Code of Conduct</a> ``` You always want to use `url_for` in case the root URL or the path to the route changes.